Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add every output support for agg graph + some agf fixes #10063

Merged
merged 2 commits into from May 11, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented May 10, 2018

Support for the following output formats for agg custom graph:

- non interactive ascii-> blank 
- interactive ascii    -> v     
- tiny ascii           -> t
- graphviz dot         -> d  
- json                 -> j 
- gml                  -> g  
- SDB key-value        -> k 
- r2 commands          -> *  
- web/png              -> w  

NOTE: this pr will change the behaviour of the aggv command: now it is renamed to aggw. (this is because "v" format is for interactive ascii).

I also added some fixes to my previous pr (for the agf output format support), mostly to remove \t tabs in the terminal output.

@radare
Copy link
Collaborator

@radare radare commented May 10, 2018

plz rebase

@cyanpencil cyanpencil force-pushed the cyanpencil:agg-output-formats branch from e0350a2 to f6fa328 May 10, 2018
@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented May 10, 2018

Unfortunately the problem wasn't the rebase...
I think I messed up a free() somewhere. Let me double check

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented May 10, 2018

I think I found it, I was doing a double free inside cconfig.c when the "dot " program viewer wasn't on the system, so I never had the segfault locally, but only on travis

@radare radare merged commit 731b067 into radareorg:master May 11, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@radare
Copy link
Collaborator

@radare radare commented May 11, 2018

thanks!

SakiiR pushed a commit to SakiiR/radare2 that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants