Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for every output format for callgraph (agc and agC) #10103

Merged
merged 2 commits into from May 15, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented May 15, 2018

Support for the various output formats for the agc function callgraph and the agC global callgraph.

Refactored a bit r_core_anal_callgraph() (mostly to remove tabs in output and use more intuitive flags for the format option)

Removed graph.format option, as the format can be specified directly from the command.

Note: when using the g format letter such as in agcg, agc always uses "gmlfcn" format, while agCg always uses "gml", because I think that's what the user would do in 99.9% of the cases. However if you think that it's confusing using the same letter for both tell me and I'll change it.

fix whitespace inside canal.c

Removed graph.format option

Removed comments in canal.c
@@ -45,6 +45,13 @@ R_LIB_VERSION_HEADER(r_core);
#define R_CORE_ANAL_KEYVALUE 16
#define R_CORE_ANAL_JSON_FORMAT_DISASM 32

#define R_CALLGRAPH_FORMAT_NO 0

This comment has been minimized.

@radare

radare May 15, 2018
Collaborator

what about R_GRAPH_FORMAT insteado? RCallGraph is not a thing

This comment has been minimized.

@cyanpencil

cyanpencil May 15, 2018
Author Contributor

ok, fixed it

@radare radare merged commit 0c9b96b into radareorg:master May 15, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
SakiiR pushed a commit to SakiiR/radare2 that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants