Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import graph (agi) + new ag? help #10132

Merged
merged 4 commits into from May 20, 2018
Merged

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented May 19, 2018

Added the import graph, which is basically a cross-references graph to all the imports.

Also, since all graph types are mostly done, I decided that it was time to update ag? help.

I also changed agv command, which before behaved like agfw: now it is just an alias for agfv, to remain consistent with the v format character (interactive ascii) of the other ag commands.

Fixed one or two things from my last pr (in particular, there was a compiler warning about unused variables).

After this pr what's left to do is addressing some issues with argument handling (the infamous agj @ 0) and adding capital letters for global graphs (which shouldn't be difficult) and then I think I'll have finished with ag*

cyanpencil added 2 commits May 19, 2018
Removed agg? help

Removed unused variable warning
Fix of string arguments in ag* commands

Fix whitespace
"agv", "", "Show function graph in web/png (see graph.web and cmd.graph) or agf for asciiart",
"Usage:", "ag<graphtype><format> [addr]", "",
"Graph types:", "", "",
"c", " [fcn addr]", "Function callgraph",

This comment has been minimized.

@radare

radare May 19, 2018
Collaborator

you shuold put the whole command in here, otherwise it will break ?* to enumerate all recursive commands

@@ -5992,6 +5982,28 @@ static void cmd_anal_graph(RCore *core, const char *input) {
break;
}
break;
case 'i': // agi "import graph"

This comment has been minimized.

@radare

radare May 19, 2018
Collaborator

put quotes around "agi", we use this to find where the commands are implemented by greeping for this expresssion which have very few false positives

Copy link
Collaborator

@radare radare left a comment

please review

@radare radare merged commit 03a132f into radareorg:master May 20, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cyanpencil cyanpencil deleted the cyanpencil:agi-import-graph branch May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants