Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ag argument handling + fix agj @ 0 #10175

Merged
merged 3 commits into from May 23, 2018
Merged

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented May 23, 2018

Fixes #8385 and fixes #9716

Now ag* commands correctly support arguments (there are some exceptions, like for example the import graph, but the ag? help specifies which commands don't take any arguments).

Also, agj and other commands won't print all the functions of the file when provided with the 0 argument: now the special address is UT64_MAX (0xffffffffffffffff or -1) that was already used by agC global callgraph

Also, global graphs now work only in the [graph.from, graph.to] range.

cyanpencil added 3 commits May 23, 2018
Added grd->follow_offset for better arg handling in ag*
Updated graph.from graph.to help

Updated visual help

Removed cmd.graph unused config variable

Whitespace cleanup
@radare radare merged commit 8a65873 into radareorg:master May 23, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@cyanpencil cyanpencil deleted the cyanpencil:ag-argument-handling branch May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants