Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asm.lines.jmp and make asm.lines config var for all lines #10254

Merged
merged 4 commits into from Jun 4, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jun 3, 2018

Now asm.lines.jmp is like the old asm.lines.

asm.lines now instead controls every kind of line. If that is false, no line of any kind is displayed.

r2r pr: https://github.com/radare/radare2-regressions/pull/1335

@XVilka
Copy link
Contributor

@XVilka XVilka commented Jun 4, 2018

Good. Maybe rename asm.lines.jmp to asm.lines.bb?

@radare
Copy link
Collaborator

@radare radare commented Jun 4, 2018

will merge after i merge my op.sign pr

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented Jun 4, 2018

Let me update asm.lines.jmp to asm.lines.bb as XVlika suggested, before merging... I'll be done in a hour or so (I have to update tests as well)

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented Jun 4, 2018

@radare radare merged commit b119dad into radareorg:master Jun 4, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants