Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panels horizontal scroll glitch + fix some coverity defects #10351

Merged
merged 2 commits into from Jun 14, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jun 14, 2018

This should close #10339

Also fixes some coverity issues in canvas.c:
if the realloc() inside expand_line fails, instead of freeing the entire canvas, just abort the write, or else all future writes will fail (and from what I understand there were many defects just for this problem)

Before considering merging, I would like to wait to check if #10339 is really fixed (I was only able to reproduce it in a virtual machine)

@radare radare merged commit 5c1ce98 into radareorg:master Jun 14, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants