Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color bugs in panels + other coverity issues in panels.c #10363

Merged
merged 1 commit into from Jun 16, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jun 16, 2018

Fixed some color bugs in canvas.c

This is a dump of the canvas output before:
2018-06-16-115750_615x895_scrot

Notice how many useless color attr were there that slowed down things (most of the time there was an attr for every char in output).

After:
2018-06-16-153639_626x925_scrot

Now it's a bit better but not perfect. Panels with color are still very slow and laggy, there is still a lot to do.

Fixed a crash when pressing C to disable color. Fixed also the 4 new coverity bugs in panels.c

@cyanpencil cyanpencil force-pushed the cyanpencil:fix-panels-color branch 2 times, most recently from 5dfc7b7 to a6ab61f Jun 16, 2018
@cyanpencil cyanpencil force-pushed the cyanpencil:fix-panels-color branch from a6ab61f to 2a1fe0c Jun 16, 2018
@radare radare merged commit c3366d9 into radareorg:master Jun 16, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants