Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in panels: correct color crop + correct rendering of graph in panels #10422

Merged
merged 3 commits into from Jun 20, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jun 20, 2018

This pr solves a lot of bugs related to utf8 in panels.

Special thanks to @radare who found out many of them.

Anyway, there are a lot of them left, for example:

  • Graph in panels don't reder very well if it is not the leftmost panel
  • Opening a menu item while having utf8 graph in panels segfaults

which I'll try to solve in a later pr

A note for @radare:
This reverts a line from one of your last prs, from:
*s = Color_RESET;
to:
*s = 0;

I think you changed it because *s = '\0' gave a compiler error, but Color_RESET breaks all colors in panels. Instead *s = 0 shouldn't give any warning (but I tried only with gcc).
Please tell me if you think it's wrong

cyanpencil added 2 commits Jun 18, 2018
Fix use after free in canvas resize

Fix utf8 working only in leftmost panel
@cyanpencil cyanpencil force-pushed the cyanpencil:panels-fix branch from bca408c to 62fcbe7 Jun 20, 2018
@cyanpencil cyanpencil force-pushed the cyanpencil:panels-fix branch from 45c2843 to f2a56ab Jun 20, 2018
@radare radare merged commit dd6533e into radareorg:master Jun 20, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants