Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to old graph edges positioning (added an option) #10430

Merged
merged 3 commits into from Jun 20, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jun 20, 2018

Closes #10400

Added option that reverts to old method of positioning edges. This option is on by default, since old edges were better in most cases. I will continue and try to finish the new edges before release.

This is better than reverting my last graph edges pr since it fixed other small things too (like enlarging of nodes with many edges, and some improvements on vertical layout)

I had changed a test in that pr, so here is that test reverted: https://github.com/radare/radare2-regressions/pull/1364

ALSO I included a typo fix in canvas.c that I forgot in my last pr

@cyanpencil cyanpencil changed the title Graph edges fix Revert to old graph edges positioning (added an option) Jun 20, 2018
@radare radare merged commit 38bb81f into radareorg:master Jun 20, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants