Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fullwidth characters of the CJK charset (Chinese, Japanese, Korean). #10579

Merged
merged 2 commits into from Jul 3, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jul 2, 2018

R2 doesn't support fullwidth characters (chars that take up two cells of the terminal), this can be reproduced easily by creating a comment like CC 逆向工程 and going to either visual disasm, graph or panels view.
Sometimes the line right below gets duplicated, or the panels and graph layout break down:
2018-07-02-190554_479x271_scrot

This is because those characters occupy two cells instead of one, thus messing up all layout calculations:
2018-07-02-190820_212x65_scrot

This pr is intended to fix those kind of things. Please, test it if you can, as there are a lot of corner cases. I fixed all of the things I could see, but I'm not sure I've got them all.

@cyanpencil
Copy link
Contributor Author

@cyanpencil cyanpencil commented Jul 2, 2018

(travis is angry because of some unrelated java stuff)

@XVilka
Copy link
Contributor

@XVilka XVilka commented Jul 3, 2018

I think lets merge it, to see what Coverity says and waiting for more users feedback.

@XVilka XVilka merged commit 602c8bf into radareorg:master Jul 3, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@radare
Copy link
Collaborator

@radare radare commented Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants