Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10719 line graph not correctly #10721

Merged
merged 1 commit into from Jul 13, 2018
Merged

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jul 12, 2018

Closes #10719
Basically the fix was letting r2 set up duplicate edges AT FIRST,
then deleting them after r2 set up backedges.

Not allowing dup edges was interfering with backedges or edges drawing in general, in particular cases (where there was a backedge from a direct neighbour).

@@ -2125,6 +2125,23 @@ static void get_bbupdate(RAGraph *g, RCore *core, RAnalFunction *fcn) {
core->anal->stackptr = saved_stackptr;
}

static void delete_dup_edges (RAGraph *g) {

This comment has been minimized.

@XVilka

XVilka Jul 13, 2018
Contributor

This would probably slow down graphs a bit, but correctness is more important

This comment has been minimized.

@XVilka

XVilka Jul 13, 2018
Contributor

Lets keep optimization for later then

@XVilka XVilka merged commit fdd4b30 into radareorg:master Jul 13, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants