Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10690 + fix delete_dup_edges #10728

Merged
merged 2 commits into from Jul 14, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jul 13, 2018

Closes #10690

Before:
image

After:
image

Also, there were some errors in the delete_dup_edges function I introduced in my last pr:

  1. ASAN gave a use after free, which was fixed by using r_list_foreach_safe and a bit of iterator pointer juggling

  2. It made more than half of useless checks. Now it takes at least half the time (however I didn't measure how much it impacted overall performance)

@radare radare merged commit 653064d into radareorg:master Jul 14, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants