Fix regression in master by adding
So this adds the
This way, now users can add (or delete) type analysis comments themselves.
This is done to fix the regression in master, together with pr: https://github.com/radare/radare2-regressions/pull/1404
(Also included a small fix in r_print.h that generated a lot of compiler warning, special thanks to @sivaramaaa that reported it!)
@ret2libc I tried to do that first, but I found out that using the same cmd_meta_comment () was giving much more functionality without any drastical changes to r_meta API.
In particular, it made possible to the user to add type analysis comments himself, with
But imho I think the most elegant solution is what @kazarmy suggest, that is dealing with different comments through subtypes: we could design a general system for handling many types of different comments at once, thus solving #5716 too at the same time. (but I also think that this should be done in a later pr, not in this one)
However as I said on tg I'm pretty unfamiliar with the r_meta part of the code, and so if you think that it should go into cmd_meta_hsdmf () for consistency reasons, I'll change it.
I see. I'm not very familiar with it neither, but from a quick look it seems it's already possible for users to do
So, my 2 cents is that we keep using cmd_meta_hsdmf just for consistency (even if that code doesn't look too good IMHO). @radare ?