Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate command history for sdb shell "ks" #10820

Merged
merged 2 commits into from Jul 27, 2018

Conversation

@cyanpencil
Copy link
Contributor

@cyanpencil cyanpencil commented Jul 25, 2018

Closes #7649
Since I couldn't reuse RLineHistory, I added a simple list to RLine to keep last sdbshell commands.
I also check that a duplicate command is not inserted more than once (like dietline does)

@ret2libc
Copy link
Contributor

@ret2libc ret2libc commented Jul 25, 2018

I didn't really check, but... what about replacing core->cons->line with a new RLine (from r_line_new()) and using cmd_history_up and cmd_history_down?

@ret2libc
Copy link
Contributor

@ret2libc ret2libc commented Jul 25, 2018

Mmm, that's bad... most of the functions which work on RLine (e.g. r_line_history_add, etc.) use r_line_instance which is global...

@radare radare merged commit 046af40 into radareorg:master Jul 27, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants