Skip to content

refactor: remove redundant continue in for loops #12087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radare merged 1 commit into from
Nov 7, 2018
Merged

refactor: remove redundant continue in for loops #12087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions libr/asm/arch/mips/gnu/mips-dis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,9 +1832,7 @@ print_mips16_insn_arg (char type,
(*info->fprintf_func) (info->stream, ", %s",
mips_gpr_names[i == 8 ? 30 : (16 + i)]);
/* Skip over string of set bits. */
for (j = i; smask & (2 << j); j++) {
continue;
}
for (j = i; smask & (2 << j); j++) {}
if (j > i) {
(*info->fprintf_func) (info->stream, "-%s",
mips_gpr_names[j == 8 ? 30 : (16 + j)]);
Expand Down
8 changes: 2 additions & 6 deletions libr/magic/apprentice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,9 +1252,7 @@ static int parse(RMagic *ms, struct r_magic_entry **mentryp, ut32 *nmentryp, con
++l;
m->flag |= NOSPACE;
}
for (i = 0; (m->desc[i++] = *l++) != '\0' && i < sizeof (m->desc);) {
continue;
}
for (i = 0; (m->desc[i++] = *l++) != '\0' && i < sizeof (m->desc);) {}
if (i == sizeof (m->desc)) {
m->desc[sizeof (m->desc) - 1] = '\0';
if (ms->flags & R_MAGIC_CHECK) {
Expand Down Expand Up @@ -1308,9 +1306,7 @@ static int parse_mime(RMagic *ms, struct r_magic_entry **mentryp, ut32 *nmentryp
EATAB;
for (i = 0;
*l && ((isascii ((ut8)*l) && isalnum ((ut8)*l)) || strchr ("-+/.", *l)) && i < sizeof (m->mimetype);
m->mimetype[i++] = *l++) {
continue;
}
m->mimetype[i++] = *l++) {}
if (i == sizeof (m->mimetype)) {
m->desc[sizeof (m->mimetype) - 1] = '\0';
if (ms->flags & R_MAGIC_CHECK) {
Expand Down
4 changes: 1 addition & 3 deletions libr/magic/softmagic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,7 @@ char * strdupn(const char *str, size_t n) {
size_t len;
char *copy;

for (len = 0; len < n && str[len]; len++) {
continue;
}
for (len = 0; len < n && str[len]; len++) {}
if (!(copy = malloc (len + 1))) {
return NULL;
}
Expand Down