Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GDB] Longer timeout and better failure handling for response to qSupported packet #14104

Merged
merged 1 commit into from May 19, 2019

Conversation

SrimantaBarua
Copy link
Contributor

Related to #14090

@SrimantaBarua SrimantaBarua changed the title [GDB] Longer timeout and better failure handling for response to qSupported packet [WIP | GDB] Longer timeout and better failure handling for response to qSupported packet May 19, 2019
@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #14104 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14104      +/-   ##
==========================================
- Coverage    36.9%    36.9%   -0.01%     
==========================================
  Files         949      949              
  Lines      304732   304740       +8     
==========================================
- Hits       112454   112452       -2     
- Misses     192278   192288      +10
Impacted Files Coverage Δ
shlr/gdb/src/libgdbr.c 0% <0%> (ø) ⬆️
shlr/gdb/src/common.c 0% <0%> (ø) ⬆️
shlr/gdb/src/gdbclient/core.c 0% <0%> (ø) ⬆️
libr/core/project.c 57.47% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41912af...e9a98ee. Read the comment docs.

@SrimantaBarua SrimantaBarua changed the title [WIP | GDB] Longer timeout and better failure handling for response to qSupported packet [GDB] Longer timeout and better failure handling for response to qSupported packet May 19, 2019
packet on timeout. Do this 5 times, and then bail out.
@SrimantaBarua
Copy link
Contributor Author

I think this can be merged.

@radare
Copy link
Collaborator

radare commented May 19, 2019 via email

@radare radare merged commit e951ba7 into radareorg:master May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants