Initial implementation of heap parsing for Windows #14218
Conversation
GustavoLCR
force-pushed
the
windows-heap
branch
3 times, most recently
from
802a17f
to
7c9dc6a
Compare
| Tested only on Windows 10 1809 x64 | ||
| TODO: | ||
| Clean/organize this: Order and Style | ||
| -Can this be useful in unix? does mdmp even have a heap? remote dbg session? |
There was a problem hiding this comment.
yes! may be cool for remote debug!
|
It also might be integrated with WinDbg/KD support: |
Codecov Report
@@ Coverage Diff @@
## master #14218 +/- ##
==========================================
- Coverage 37.83% 37.83% -0.01%
==========================================
Files 949 949
Lines 305172 305240 +68
==========================================
+ Hits 115469 115475 +6
- Misses 189703 189765 +62
Continue to review full report at Codecov.
|
| #define WINDOWS_MAPS_H | ||
| #include <r_core.h> | ||
|
|
||
| R_API RList *w32_dbg_modules(RDebug *dbg); |
There was a problem hiding this comment.
public fcn namespacec violation
| @@ -833,7 +617,7 @@ static RDebugPid *build_debug_pid(PROCESSENTRY32 *pe) { | |||
| return ret; | |||
| } | |||
|
|
|||
| RList *w32_pids (int pid, RList *list) { | |||
| RList *w32_pids(int pid, RList *list) { | |||
There was a problem hiding this comment.
why get a list to return it? just create it inside this funtion and remove the arg
There was a problem hiding this comment.
show_all_pids should be bool
There was a problem hiding this comment.
why get a list to return it? just create it inside this funtion and remove the arg
I checked and the equivalent functions for the other platforms also ask for a list. I wont change them because it is out of scope for this pr
libr/util/w32-sys.c
Outdated
| @@ -27,6 +27,45 @@ static char *getexe(const char *str) { | |||
| return argv0; | |||
| } | |||
|
|
|||
| R_API ut32 r_sys_get_winver() { | |||
There was a problem hiding this comment.
what about making this funcction generic and make it work with uname on unix systems too instead of being windows-specific
There was a problem hiding this comment.
@radare I implemented r_sys_get_osinfo(). Can you check to see if thats what you wanted?
XVilka
added
Windows
|
Cool thanks! Lets wait for travis :) |
Only tested on Windows 10 x64, but at least the basics should work on every version.
Also please review