Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #14681

Merged
merged 2 commits into from Jul 28, 2019
Merged

Refactoring #14681

merged 2 commits into from Jul 28, 2019

Conversation

@Vane11ope
Copy link
Collaborator

Vane11ope commented Jul 28, 2019

No description provided.

@@ -281,8 +281,9 @@ static void __init_all_dbs(RCore *core);
static void __init_panel_param(RCore *core, RPanel *p, const char *title, const char *cmd);
static RPanels *__panels_new(RCore *core);
static void __init_new_panels_root(RCore *core);
static void __init_menu_saved_layout (RCore *core);
static void __init_menu_disasm_settings_layout (void *_core);
static void __init_menu_saved_layout (void *core, const char *parent);

This comment has been minimized.

Copy link
@ret2libc

ret2libc Jul 28, 2019

Collaborator

we don't use the space between the function name and the parameters.
So it should be

static void __init_menu_saved_layout(void *core, const char *parent);
@radare radare merged commit 9706763 into radareorg:master Jul 28, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
@radare

This comment has been minimized.

Copy link
Collaborator

radare commented Jul 28, 2019

try to use meaningful commit names please

@Vane11ope Vane11ope deleted the Vane11ope:vane11ope/panels branch Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.