Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactoring #14681
Merged
Refactoring #14681
Conversation
libr/core/panels.c
Outdated
| @@ -281,8 +281,9 @@ static void __init_all_dbs(RCore *core); | |||
| static void __init_panel_param(RCore *core, RPanel *p, const char *title, const char *cmd); | |||
| static RPanels *__panels_new(RCore *core); | |||
| static void __init_new_panels_root(RCore *core); | |||
| static void __init_menu_saved_layout (RCore *core); | |||
| static void __init_menu_disasm_settings_layout (void *_core); | |||
| static void __init_menu_saved_layout (void *core, const char *parent); | |||
This comment has been minimized.
This comment has been minimized.
ret2libc
Jul 28, 2019
Collaborator
we don't use the space between the function name and the parameters.
So it should be
static void __init_menu_saved_layout(void *core, const char *parent);
This comment has been minimized.
This comment has been minimized.
|
try to use meaningful commit names please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Vane11ope commentedJul 28, 2019
No description provided.