Annotation for function name #17204
Merged
Annotation for function name #17204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would recommend keeping changes in separate branch just like it is currently done with matching cutter changes. |
|
@karliss Sure, I will make a branch with the same name |
karliss
reviewed
Jul 3, 2020
leaks memory currently
thestr4ng3r
approved these changes
Jul 9, 2020
karliss
approved these changes
Jul 9, 2020
|
@NirmalManoj @karliss @thestr4ng3r do we need to merge it in master? Or it's preliminary yet? |
|
@XVilka I haven't made unit tests for function name annotation yet, and I think it will be better if that's done later after all new types of annotations are added. Also, this PR won't improve |
NirmalManoj
added a commit
that referenced
this pull request
Jul 17, 2020
NirmalManoj
added a commit
that referenced
this pull request
Jul 26, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Aug 6, 2020
NirmalManoj
added a commit
that referenced
this pull request
Aug 9, 2020
3 tasks
ITAYC0HEN
pushed a commit
that referenced
this pull request
Aug 10, 2020
…edCode (#17429) * Annotation for function name (#17204) * Annotations for Constant Variables and Global Variables for the decompiler (#17281) * Annotation For Function Variables (#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (#17386) * Update docs in annotate code API (#17397) * Unit tests for annotated code API (#17403)
ret2libc
pushed a commit
to ret2libc/radare2
that referenced
this pull request
Sep 1, 2020
…edCode (radareorg#17429) * Annotation for function name (radareorg#17204) * Annotations for Constant Variables and Global Variables for the decompiler (radareorg#17281) * Annotation For Function Variables (radareorg#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (radareorg#17386) * Update docs in annotate code API (radareorg#17397) * Unit tests for annotated code API (radareorg#17403)
ret2libc
pushed a commit
that referenced
this pull request
Sep 2, 2020
…edCode (#17429) * Annotation for function name (#17204) * Annotations for Constant Variables and Global Variables for the decompiler (#17281) * Annotation For Function Variables (#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (#17386) * Update docs in annotate code API (#17397) * Unit tests for annotated code API (#17403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR adds an annotation type (
R_CODE_ANNOTATION_TYPE_FUNCTION_NAME) for function names in the decompiled code. This will be required for implementing some features in the decompiler in Cutter.Note: I haven't modified tests so CI can fail during tests due to this. I will modify tests after getting feedback on this.
...
Test plan
...
Closing issues
...