Annotations for Constant Variables and Global Variables for the decompiler #17281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
trufae
approved these changes
Jul 14, 2020
karliss
reviewed
Jul 15, 2020
5 tasks
github-actions
bot
added
the
infrastructure
karliss
reviewed
Jul 16, 2020
Merged
16 tasks
karliss
approved these changes
Jul 17, 2020
NirmalManoj
force-pushed
the
decompiler-refactoring
branch
from
e284065
to
5f34144
Compare
NirmalManoj
force-pushed
the
const-global-variable-annotation
branch
from
1d267be
to
a14ad4e
Compare
trufae
approved these changes
Jul 18, 2020
|
Please merge. |
|
@NirmalManoj The PR has been accepted and tests are green. Don't you have button for doing it yourself? |
|
Just don't forget to cleanup commit message when squashing. |
|
Yes, I will merge!! It's just that I was not sure if I am supposed to do it. I have never merged a PR before. |
NirmalManoj
added a commit
that referenced
this pull request
Jul 26, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Jul 28, 2020
NirmalManoj
added a commit
to NirmalManoj/radare2
that referenced
this pull request
Aug 6, 2020
NirmalManoj
added a commit
that referenced
this pull request
Aug 9, 2020
3 tasks
ITAYC0HEN
pushed a commit
that referenced
this pull request
Aug 10, 2020
…edCode (#17429) * Annotation for function name (#17204) * Annotations for Constant Variables and Global Variables for the decompiler (#17281) * Annotation For Function Variables (#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (#17386) * Update docs in annotate code API (#17397) * Unit tests for annotated code API (#17403)
ret2libc
pushed a commit
to ret2libc/radare2
that referenced
this pull request
Sep 1, 2020
…edCode (radareorg#17429) * Annotation for function name (radareorg#17204) * Annotations for Constant Variables and Global Variables for the decompiler (radareorg#17281) * Annotation For Function Variables (radareorg#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (radareorg#17386) * Update docs in annotate code API (radareorg#17397) * Unit tests for annotated code API (radareorg#17403)
ret2libc
pushed a commit
that referenced
this pull request
Sep 2, 2020
…edCode (#17429) * Annotation for function name (#17204) * Annotations for Constant Variables and Global Variables for the decompiler (#17281) * Annotation For Function Variables (#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (#17386) * Update docs in annotate code API (#17397) * Unit tests for annotated code API (#17403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR implements annotations for constant and global variables. As of now, the only information that is stored in the annotation is the address of the constant/global variable. The actions in Cutter that we will be having using these annotations is to add/rename/delete flags at the address of constant/global variables. See the corresponding PR #124 in r2ghidra-dec
...
Test plan
...
Closing issues
...