Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations for Constant Variables and Global Variables for the decompiler #17281

Conversation

NirmalManoj
Copy link
Contributor

@NirmalManoj NirmalManoj commented Jul 14, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
This PR implements annotations for constant and global variables. As of now, the only information that is stored in the annotation is the address of the constant/global variable. The actions in Cutter that we will be having using these annotations is to add/rename/delete flags at the address of constant/global variables. See the corresponding PR #124 in r2ghidra-dec

...

Test plan

  • 1. Compile PR #124 in r2ghidra-dec after compiling this PR.
  • 2. Make sure JSON output is working as expected.
  • 3. Look at code.
  • 4. Think if we need more information in annotations for having the action described above in Cutter.

...

Closing issues

...

@NirmalManoj NirmalManoj marked this pull request as ready for review Jul 14, 2020
@NirmalManoj NirmalManoj requested a review from trufae as a code owner Jul 14, 2020
@NirmalManoj NirmalManoj requested review from thestr4ng3r and karliss Jul 14, 2020
@NirmalManoj NirmalManoj self-assigned this Jul 14, 2020
@github-actions github-actions bot added the API New API requests, changes, removal label Jul 14, 2020
trufae
trufae approved these changes Jul 14, 2020
@NirmalManoj NirmalManoj requested a review from karliss Jul 15, 2020
@github-actions github-actions bot added the infrastructure Issues related to the radare2/cutter infrastructure label Jul 15, 2020
@NirmalManoj NirmalManoj requested a review from ret2libc as a code owner Jul 15, 2020
.appveyor.yml Show resolved Hide resolved
@NirmalManoj NirmalManoj force-pushed the const-global-variable-annotation branch from 1d267be to a14ad4e Compare Jul 17, 2020
trufae
trufae approved these changes Jul 18, 2020
@NirmalManoj
Copy link
Contributor Author

NirmalManoj commented Jul 18, 2020

Please merge.

@karliss
Copy link
Contributor

karliss commented Jul 18, 2020

@NirmalManoj The PR has been accepted and tests are green. Don't you have button for doing it yourself?

@karliss
Copy link
Contributor

karliss commented Jul 18, 2020

Just don't forget to cleanup commit message when squashing.

@NirmalManoj
Copy link
Contributor Author

NirmalManoj commented Jul 18, 2020

Yes, I will merge!! It's just that I was not sure if I am supposed to do it. I have never merged a PR before.

@NirmalManoj NirmalManoj merged commit 6ee13f6 into radareorg:decompiler-refactoring Jul 18, 2020
14 checks passed
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Jul 28, 2020
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Jul 28, 2020
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Jul 28, 2020
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Jul 28, 2020
@NirmalManoj NirmalManoj moved this from In progress to Done in Improving Decompiler Widget (GSoC) Jul 29, 2020
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Aug 6, 2020
ITAYC0HEN pushed a commit that referenced this pull request Aug 10, 2020
…edCode (#17429)

* Annotation for function name (#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (#17281)
* Annotation For Function Variables (#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (#17386)
* Update docs in annotate code API  (#17397)
* Unit tests for annotated code API (#17403)
ret2libc pushed a commit to ret2libc/radare2 that referenced this pull request Sep 1, 2020
…edCode (radareorg#17429)

* Annotation for function name (radareorg#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (radareorg#17281)
* Annotation For Function Variables (radareorg#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (radareorg#17386)
* Update docs in annotate code API  (radareorg#17397)
* Unit tests for annotated code API (radareorg#17403)
ret2libc pushed a commit that referenced this pull request Sep 2, 2020
…edCode (#17429)

* Annotation for function name (#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (#17281)
* Annotation For Function Variables (#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (#17386)
* Update docs in annotate code API  (#17397)
* Unit tests for annotated code API (#17403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API New API requests, changes, removal infrastructure Issues related to the radare2/cutter infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants