Skip to content

Unit tests for annotated code API - #17403

Merged
ITAYC0HEN merged 4 commits into
radareorg:decompiler-refactoringfrom
NirmalManoj:unit-test-annotated-code
Aug 5, 2020
Merged

Unit tests for annotated code API#17403
ITAYC0HEN merged 4 commits into
radareorg:decompiler-refactoringfrom
NirmalManoj:unit-test-annotated-code

Conversation

@NirmalManoj

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
This PR implements unit tests for the following API:

  1. r_annotation_is_reference()
  2. r_annotation_is_variable()
  3. r_annotation_free()
  4. JSON printing for context-related annotations.

...

Test plan

  1. Run make unit from the test directory and make sure tests pass.
  2. Check code.
  3. Try to see if I should implement tests for anything else related to RAnnotatedCode.

...

Closing issues

...

@NirmalManoj
NirmalManoj requested a review from trufae as a code owner August 4, 2020 17:47
@NirmalManoj NirmalManoj self-assigned this Aug 4, 2020
@github-actions github-actions Bot added the r2r Regression tests label Aug 4, 2020
@ITAYC0HEN
ITAYC0HEN merged commit 6f56d6c into radareorg:decompiler-refactoring Aug 5, 2020
NirmalManoj added a commit to NirmalManoj/radare2 that referenced this pull request Aug 6, 2020
NirmalManoj added a commit that referenced this pull request Aug 9, 2020
ITAYC0HEN pushed a commit that referenced this pull request Aug 10, 2020
…edCode (#17429)

* Annotation for function name (#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (#17281)
* Annotation For Function Variables (#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (#17386)
* Update docs in annotate code API  (#17397)
* Unit tests for annotated code API (#17403)
ret2libc pushed a commit to ret2libc/radare2 that referenced this pull request Sep 1, 2020
…edCode (radareorg#17429)

* Annotation for function name (radareorg#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (radareorg#17281)
* Annotation For Function Variables (radareorg#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (radareorg#17386)
* Update docs in annotate code API  (radareorg#17397)
* Unit tests for annotated code API (radareorg#17403)
ret2libc pushed a commit that referenced this pull request Sep 2, 2020
…edCode (#17429)

* Annotation for function name (#17204)
* Annotations for Constant Variables and Global Variables for the decompiler (#17281)
* Annotation For Function Variables (#17375)
* function variable annotation added (includes local variable and function parameter)
* API for checking if an annotation is a reference or function variable. (#17386)
* Update docs in annotate code API  (#17397)
* Unit tests for annotated code API (#17403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r2r Regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants