New annotations and API functions for the decompiler #17429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* function variable annotation added (includes local variable and function parameter)
NirmalManoj
requested review from
ret2libc,
thestr4ng3r and
trufae
as code owners
github-actions
bot
added
API
ITAYC0HEN
reviewed
Aug 9, 2020
| } | ||
|
|
||
| R_API bool r_annotation_is_reference(RCodeAnnotation *annotation) { | ||
| return (annotation->type == R_CODE_ANNOTATION_TYPE_GLOBAL_VARIABLE || annotation->type == R_CODE_ANNOTATION_TYPE_CONSTANT_VARIABLE || annotation->type == R_CODE_ANNOTATION_TYPE_FUNCTION_NAME); |
There was a problem hiding this comment.
Can you make this LOC shorter by splitting the conditions in new lines? Had to enable line-wrap here
There was a problem hiding this comment.
@ITAYC0HEN Can you tell me how I can do that? When I tried it earlier, the coding style checker was telling me to not split it into multiple lines.
There was a problem hiding this comment.
Then I have no idea :)
That's only a small nice-to-have, if it causes a problem then no worries, you can skip this request
|
I think |
|
@NirmalManoj yes, it's #17395. You can ignore this particular one. |
XVilka
approved these changes
Aug 10, 2020
karliss
approved these changes
Aug 10, 2020
|
Thank you Nirmal! Fantastic work <3 |
ret2libc
added a commit
to ret2libc/radare2
that referenced
this pull request
Aug 31, 2020
…RAnnotatedCode (radareorg#17429)" This reverts commit b4677b4.
ret2libc
added a commit
to ret2libc/radare2
that referenced
this pull request
Aug 31, 2020
…RAnnotatedCode (radareorg#17429)" This reverts commit b4677b4.
ret2libc
pushed a commit
to ret2libc/radare2
that referenced
this pull request
Sep 1, 2020
…edCode (radareorg#17429) * Annotation for function name (radareorg#17204) * Annotations for Constant Variables and Global Variables for the decompiler (radareorg#17281) * Annotation For Function Variables (radareorg#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (radareorg#17386) * Update docs in annotate code API (radareorg#17397) * Unit tests for annotated code API (radareorg#17403)
ret2libc
pushed a commit
that referenced
this pull request
Sep 2, 2020
…edCode (#17429) * Annotation for function name (#17204) * Annotations for Constant Variables and Global Variables for the decompiler (#17281) * Annotation For Function Variables (#17375) * function variable annotation added (includes local variable and function parameter) * API for checking if an annotation is a reference or function variable. (#17386) * Update docs in annotate code API (#17397) * Unit tests for annotated code API (#17403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
As part of the Improving Decompiler Widget project, many new types of annotations and new API functions have been implemented by the following PRs to the
decompiler-refactoringbranch. This PR is for merging these to the master....
Test plan
decompiler-refactoringbranch from the r2ghidra-dec and use the commandpdgjfor the JSON output. See if it's working as expected....
Closing issues
...