Patch Escape Sequence Injection Bypass - #22385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A follow up to CVE-2023-0302.
Since the original report I've learned of C1 control codes, which would make a bypass possible.
Additionally, the original fix would allow a trailing ESC character to pass through, also allowing a bypass by splitting the rest of the sequence to a consecutive print.
Also, added BEL, ENQ and DEL to the sanitization due to their potential for abuse.
I tried my best to preserve original behavior to not cause side effects in dependent code.
I might not be able to add the tests in the next couple of days. FYI, in case that's a blocker.