New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleCASTNode #145

Merged
merged 22 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants
@kriw
Collaborator

kriw commented May 16, 2018

This issue is related to #136

TODO:

  • Implement a converter to CAST from SimpleCAST
    • Revise (or add methods) struct c_simple::CAST
  • Write unit tests

@kriw kriw referenced this pull request May 16, 2018

Closed

C AST Architecture Discussion #136

}
/// Returns nodes which is connected with given type of edge
fn neighbors_by_edge(edges: &Vec<EdgeReference<SimpleCASTEdge>>, ty: &SimpleCASTEdge) -> Vec<NodeIndex> {

This comment has been minimized.

@chinmaydd

chinmaydd May 16, 2018

Contributor

Hey @kriw , any specific reason why this method is not part of the impl for SimpleCAST?

This comment has been minimized.

@kriw

kriw May 16, 2018

Collaborator

Because the function does not involves SimpleCAST.
I thought it would be simpler.

@chinmaydd

This comment has been minimized.

Contributor

chinmaydd commented May 16, 2018

Also, are you yet to account for type information or am I missing something?

@kriw

This comment has been minimized.

Collaborator

kriw commented May 16, 2018

Yes, but I'm wondering how to implement it.
Currently, I'm planning to add type field to ValueNode::Variable and ValueNode::Constant.

kriw added some commits May 17, 2018

@kriw kriw changed the title from WIP Add SimpleCASTNode to Add SimpleCASTNode May 22, 2018

@kriw kriw referenced this pull request May 22, 2018

Closed

Add functions in c_simple.c #151

@chinmaydd

This comment has been minimized.

Contributor

chinmaydd commented May 22, 2018

Apart from a few naming conventions here and there(Eg. add_goto() and insert_goto() dont really convey the complete meaning to the API user. But since we are not in v1 we can always make changes later) this LGTM @kriw . Good work 👍 The SimpleCAST is compact and incorporates the logic we need.

P.S: I think we should implement fmt::Debug for CAST rather than having the print() method for it. Might be more helpful.

@sushant94

This comment has been minimized.

Collaborator

sushant94 commented May 23, 2018

This seems good to me! Awesome work @kriw! :)

@sushant94 sushant94 merged commit 9736432 into radareorg:master May 23, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment