New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update things related to registers #161

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
2 participants
@HMPerson1
Collaborator

HMPerson1 commented May 26, 2018

  • phiplacement uses SubRegisterFile internals directly, which still uses numbers.
  • SSA::registers and SSAMod::set_register still use strings

HMPerson1 added some commits May 26, 2018

@@ -4,10 +4,11 @@ use analysis::inst_combine;
use frontend::radeco_containers::{RadecoFunction, RadecoModule};
use middle::dce;
use middle::ir;
use middle::regfile::{RegisterId, RegisterUsage, SubRegisterFile};
use middle::regfile::*;

This comment has been minimized.

@sushant94

sushant94 May 30, 2018

Collaborator

I think you should explicitly spell out what you want to import. This helps:

  1. Makes it clear what's being imported
  2. In case more things are added to regfile, they won't "automatically" be imported here.
rfn.bindings.insert(bind);
}
}
// {

This comment has been minimized.

@sushant94

sushant94 May 30, 2018

Collaborator

Remove this code if we don't plan on using it in the immediate future. We can always bring it back if need be as its in git.

@sushant94 sushant94 merged commit def8657 into radareorg:master May 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@HMPerson1 HMPerson1 deleted the HMPerson1:reg_update branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment