New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out capstone #194

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@HMPerson1
Collaborator

HMPerson1 commented Jul 27, 2018

No description provided.

@chinmaydd

This comment has been minimized.

Show comment
Hide comment
@chinmaydd

chinmaydd Jul 27, 2018

Contributor

Are we sure we want to merge it to master ?

Contributor

chinmaydd commented Jul 27, 2018

Are we sure we want to merge it to master ?

@XVilka

This comment has been minimized.

Show comment
Hide comment
@XVilka

XVilka Jul 27, 2018

Collaborator

Can't we do both? Update capstone-rust in master and merge this one in "dev" branch?
Because if it will break some things - it might be bad for the first release.

Collaborator

XVilka commented Jul 27, 2018

Can't we do both? Update capstone-rust in master and merge this one in "dev" branch?
Because if it will break some things - it might be bad for the first release.

@chinmaydd

This comment has been minimized.

Show comment
Hide comment
@chinmaydd

chinmaydd Jul 27, 2018

Contributor

That sounds good to me 👍

Contributor

chinmaydd commented Jul 27, 2018

That sounds good to me 👍

@kriw

This comment has been minimized.

Show comment
Hide comment
@kriw

kriw Jul 30, 2018

Collaborator

LGTM :)

Collaborator

kriw commented Jul 30, 2018

LGTM :)

@HMPerson1

This comment has been minimized.

Show comment
Hide comment
@HMPerson1

HMPerson1 Jul 30, 2018

Collaborator

Merged to branch dev.

Collaborator

HMPerson1 commented Jul 30, 2018

Merged to branch dev.

@HMPerson1 HMPerson1 closed this Jul 30, 2018

@radare

This comment has been minimized.

Show comment
Hide comment
@radare

radare Jul 30, 2018

Collaborator
Collaborator

radare commented Jul 30, 2018

@HMPerson1 HMPerson1 deleted the HMPerson1:no-capstone branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment