Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out capstone #194

Closed
wants to merge 1 commit into from
Closed

Rip out capstone #194

wants to merge 1 commit into from

Conversation

@HMPerson1
Copy link
Collaborator

@HMPerson1 HMPerson1 commented Jul 27, 2018

No description provided.

@chinmaydd
Copy link
Contributor

@chinmaydd chinmaydd commented Jul 27, 2018

Are we sure we want to merge it to master ?

@XVilka
Copy link
Member

@XVilka XVilka commented Jul 27, 2018

Can't we do both? Update capstone-rust in master and merge this one in "dev" branch?
Because if it will break some things - it might be bad for the first release.

@chinmaydd
Copy link
Contributor

@chinmaydd chinmaydd commented Jul 27, 2018

That sounds good to me 👍

@kriw
Copy link
Collaborator

@kriw kriw commented Jul 30, 2018

LGTM :)

@HMPerson1
Copy link
Collaborator Author

@HMPerson1 HMPerson1 commented Jul 30, 2018

Merged to branch dev.

@HMPerson1 HMPerson1 closed this Jul 30, 2018
@radare
Copy link
Collaborator

@radare radare commented Jul 30, 2018

@HMPerson1 HMPerson1 deleted the HMPerson1:no-capstone branch Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.