Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssclass: img-captions, img-grid #44

Closed
NoodleNodes opened this issue Apr 18, 2021 · 7 comments
Closed

cssclass: img-captions, img-grid #44

NoodleNodes opened this issue Apr 18, 2021 · 7 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@NoodleNodes
Copy link

Hi @radekkozak

Just wanted to report strange behavior of theme when using cssclass in YAML at top of a note -- preview formatting is all over the place and I can't figure out why.

---
cssclass: img-captions, img-grid
---

Please see attached

screenshot 2021 04 19 00 07 14

Images are working wonderfully, however certain markdown syntax line inline code, my table of contents (links to in note headers) and footnotes are doing weird and wonderful things.

I'm not sure how to fix this myself and would be grateful if you could take a look.

All the best!

@radekkozak
Copy link
Owner

Hi @shauxesis very sorry for quite a delay - i just get out of very nasty Covid situation few days ago, still shocked a little and messed up but i'm trying slowly to get my head around things now.

I'm eager to help you with the issue, could you please send me your problematic note so i could better debug the issue

Thank you, and thanks for the patience

@radekkozak radekkozak self-assigned this Apr 26, 2021
@radekkozak radekkozak added the bug Something isn't working label Apr 26, 2021
@radekkozak radekkozak added this to To do in Discordian via automation Apr 26, 2021
@NoodleNodes
Copy link
Author

NoodleNodes commented Apr 26, 2021 via email

@radekkozak
Copy link
Owner

Thank you for understanding Shandé.

Yes, it was quite scary, still recovering from the whole experience. But per med outlines besides taking care of physical i gotta exercise my mind as well so no worries. I think it would actually be good to try to solve few things

To that end: i think i'm missing the attachment, the actual .md note that's causing the trouble would be most helpful (also i assume you use the newest version of Obsidian ?)

Thank you /cc @shauxesis

@NoodleNodes
Copy link
Author

NoodleNodes commented Apr 26, 2021 via email

@NoodleNodes
Copy link
Author

NoodleNodes commented Apr 26, 2021 via email

@radekkozak
Copy link
Owner

radekkozak commented Apr 28, 2021

This is very weird - i think github is somehow eating the file you're trying to attach. Maybe you need to zip it first or something - not sure

If you could kindly maybe send it to me directly at radoslaw.kozak@gmail.com it would be the simplest option. I think i know what might be going on but want to make sure and confirm with your .md note

Thanks again / cc @shauxesis

@radekkozak radekkozak moved this from To do to In progress in Discordian Apr 28, 2021
@radekkozak
Copy link
Owner

Hi Shandé / @shauxesis
just pasting the email i sent you and letting you know i was able to fix the problem with image grids and captions you were having.

It was a nasty one i must admit as Obsidian starting from version 0.11.3 changed how it internally groups images together entirely !

Not to bore you with details but i will explain it more in description of Discordian theme on github and at the Discordian chat in forum https://forum.obsidian.md/t/discordian-theme/10880/1 when 0.8.6 version will launch (that is TODAY ;)

Long story short: prior to Obsidian changes i advised everyone to use img-grid OR img-captions in their note as their css apply globally to all images in the note. This was main problem with the note you sent me - hence the whole havoc around it

Anyway: i decided to fix that as much as it is possible with how Obsidian works (not everything is possible unfortunately) - and took it up a notch - you will be able to use both: grids and captions inside one note but with restrictions.

Still advise to use them separately inside one note :) it’s easier that way

Anyway, thank you very much for letting me know about all of the problems. I very much appreciate it as it makes the theme better and cleaner

In the next days i will try to look what else has changed in Obsidian in the period when i was out of the grid

@radekkozak radekkozak moved this from In progress to Done in Discordian May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants