New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedwordpress generates warning after WordPress 4.7 upgrade #76

Closed
danyork opened this Issue Dec 7, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@danyork

danyork commented Dec 7, 2016

Hello! Thank you for continuing to maintain this excellent plugin. FYI, after upgrades today to WordPress 4.7, multiple users are reporting a problem that generates this warning message throughout the admin screens:

Warning: Parameter 1 to FeedWordPressHTTPAuthenticator::set_auth_options() expected to be a reference, value given in /home/danyork/public_html/wp-includes/class-wp-hook.php on line 300

These reports can be seen here:

https://wordpress.org/support/topic/broken-with-the-wordpress-4-7-update/

One person in the conversation reported a potential workaround:


Ok, so it’s very likely the wrong answer, but I removed the ampersand before the $handle parameter for FeedWordPressHTTPAuthenticator::set_auth_options() in feedwordpresshttpauthenticator.class.php and the error disappeared (and my feed imports still worked).


And others in the feed, and myself, can confirm that this works to remove the warning message. I don't know, though, and I suspect others don't know, what this has actually done.

@cogdog

This comment has been minimized.

Show comment
Hide comment
@cogdog

cogdog Dec 9, 2016

I have been doing the same fix, and am seeing fatal errors in @radgeek other plugins: FWP--Sic--EM and FWP-Add-Attribution

cogdog commented Dec 9, 2016

I have been doing the same fix, and am seeing fatal errors in @radgeek other plugins: FWP--Sic--EM and FWP-Add-Attribution

@cogdog

This comment has been minimized.

Show comment
Hide comment
@cogdog

cogdog Dec 10, 2016

Thanks for the update (via wordpress.org) @radgeek -- I cannot seem to reproduce the errors again (using the fix by @danyork). My copy of FWP--Sic--EM was out of date, and it seems to be fine with the updated one. The error on FWP-Add-Attribution was after I had disabled FWP--Add-Attribution (error for call to is_syndicated() function). AM continuing to test on a few other non critical sites.

cogdog commented Dec 10, 2016

Thanks for the update (via wordpress.org) @radgeek -- I cannot seem to reproduce the errors again (using the fix by @danyork). My copy of FWP--Sic--EM was out of date, and it seems to be fine with the updated one. The error on FWP-Add-Attribution was after I had disabled FWP--Add-Attribution (error for call to is_syndicated() function). AM continuing to test on a few other non critical sites.

@radgeek

This comment has been minimized.

Show comment
Hide comment
@radgeek

radgeek Dec 11, 2016

Owner

Thanks y'all. I'm going to do some ongoing testing to make sure that there are no untoward side-effects of the change, but for the moment, I went ahead and published a quick compatibility fix similar to what @danyork quotes from the WordPress.org issue thread. So this should be fixable by grabbing the most recent version of FWP, either from Github or from the WordPress plugins repository.

If you notice any problems with updating feeds under the new version (especially any feeds you may have that make use of HTTP Authentication), let me know and I'll reopen the issue.

Owner

radgeek commented Dec 11, 2016

Thanks y'all. I'm going to do some ongoing testing to make sure that there are no untoward side-effects of the change, but for the moment, I went ahead and published a quick compatibility fix similar to what @danyork quotes from the WordPress.org issue thread. So this should be fixable by grabbing the most recent version of FWP, either from Github or from the WordPress plugins repository.

If you notice any problems with updating feeds under the new version (especially any feeds you may have that make use of HTTP Authentication), let me know and I'll reopen the issue.

@radgeek radgeek closed this Dec 11, 2016

@netdragonboberb

This comment has been minimized.

Show comment
Hide comment
@netdragonboberb

netdragonboberb Dec 24, 2016

Slightly off-topic, but maybe helpful. I had the other error mentioned in that topic (copied below), but only after switching from php-fpm to mod-php5

Warning: call_user_func_array() expects parameter 1 to be a valid callback, no array or string given in /home/www/web411/html/bjoern/wp/wp-includes/class-wp-hook.php on line 298

netdragonboberb commented Dec 24, 2016

Slightly off-topic, but maybe helpful. I had the other error mentioned in that topic (copied below), but only after switching from php-fpm to mod-php5

Warning: call_user_func_array() expects parameter 1 to be a valid callback, no array or string given in /home/www/web411/html/bjoern/wp/wp-includes/class-wp-hook.php on line 298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment