Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syndicatedpost.class.php #47

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
3 participants
@tristanleboss
Copy link
Contributor

tristanleboss commented May 20, 2015

If you add your own feed to FeedWordPress and set FeedWordPress to store its entries in a custom post type, it won't work: FeedWordPress will use the actual content (which is dangerous because it will overwrite it with the feed content!) instead of creating a new post using the specified custom post type.

This fix is just a safeguard: in all situation, FeedWordPress should only publish the entry to a post matching the post type it was set to.

Also, the documentation should reflect the fact that using your own feed may lead to unexpected behaviors.
On my setup, I use a custom post type dedicated to FeedWordPress. This custom post type is set not to appear in the feed. This way, I avoid problems (except the one I fixed here) but if you don't do that, you may expect some odd behaviors or data corruption.

Update syndicatedpost.class.php
If you add your own feed to FeedWordPress and set FeedWordPress to store its entries in a custom post type, it won't work: FeedWordPress will use the actual content (which is dangerous because it will overwrite it with the feed content!) instead of creating a new post using the specified custom post type.

This fix is just a safeguard: in all situation, FeedWordPress should only publish the entry to a post matching the post type it was set to.

Also, the documentation should reflect the fact that using your own feed may lead to unexpected behaviors.
On my setup, I use a custom post type dedicated to FeedWordPress. This custom post type is set not to appear in the feed. This way, I avoid problems (except the one I fixed here) but if you don't do that, you may expect some odd behaviors or data corruption.
@talgalili

This comment has been minimized.

Copy link

talgalili commented Jul 13, 2018

LGTM,
@radgeek - why not merge this?

@tristanleboss

This comment has been minimized.

Copy link
Contributor Author

tristanleboss commented Jul 14, 2018

I don't know... this is a trivial fix without any conflicts with the base branch... nothing fixed htis bug since I sent this fix so the bug is still there :(

@radgeek radgeek merged commit 999ad91 into radgeek:master Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.