-
Notifications
You must be signed in to change notification settings - Fork 92
Add bean-format #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bean-format #101
Conversation
|
Test will likely fail due to #99 |
|
Interesting, what's the indentation problem? Does the formatter not work well when applied to an already-formatted file? |
|
It's just a very simple formatter that doesn't deindent, even the tests just use python |
Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
|
What do you mean by |
|
I do indeed mean reducing indentation, perhaps the tests are misusing that module then. All this does is align columns of numbers, if the indentation is wonky it doesn't adjust it. |
|
I think it's fine to leave as is. If formatting this file format requires additional functionality then it should be added into the formatter, not hacked on top in an Emacs package! |
Might also require some kind of deindent formatter (may be that we
introduce some generic formatters like that to chain other against?)
but otherwise should work fine