Skip to content

Add bean-format #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2022
Merged

Add bean-format #101

merged 7 commits into from
Jun 20, 2022

Conversation

elken
Copy link
Contributor

@elken elken commented Jun 3, 2022

Might also require some kind of deindent formatter (may be that we
introduce some generic formatters like that to chain other against?)
but otherwise should work fine

@elken
Copy link
Contributor Author

elken commented Jun 3, 2022

Test will likely fail due to #99

@raxod502
Copy link
Member

raxod502 commented Jun 4, 2022

Interesting, what's the indentation problem? Does the formatter not work well when applied to an already-formatted file?

@elken
Copy link
Contributor Author

elken commented Jun 4, 2022

It's just a very simple formatter that doesn't deindent, even the tests just use python textwrap to do that.

elken and others added 4 commits June 4, 2022 05:38
Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
Co-authored-by: Radon Rosborough <radon.neon@gmail.com>
@raxod502
Copy link
Member

What do you mean by deindent? When I hear that word I think of reducing the indentation level of a block of code, but your reference to the textwrap module makes me think you're talking about hard-wrapping long lines of text into paragraphs.

@elken
Copy link
Contributor Author

elken commented Jun 14, 2022

I do indeed mean reducing indentation, perhaps the tests are misusing that module then.

All this does is align columns of numbers, if the indentation is wonky it doesn't adjust it.

@raxod502
Copy link
Member

I think it's fine to leave as is. If formatting this file format requires additional functionality then it should be added into the formatter, not hacked on top in an Emacs package!

@raxod502 raxod502 merged commit ac6f733 into radian-software:main Jun 20, 2022
@elken elken deleted the feat/add-bean-format branch June 21, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants