Back / forward gestures #50

Closed
JohnMaguire opened this Issue Mar 2, 2014 · 14 comments

Comments

Projects
None yet
3 participants

I see in #23 that back/forward buttons were added, but it'd be really nice if we could use the OS X trackpad gestures for back/forward to do the same thing. This is how I typically navigate through Play Music.

@kbhomes kbhomes added this to the v1.0.3 milestone Mar 2, 2014

Owner

kbhomes commented Mar 3, 2014

In a previous commit I expanded the gestures to include the two-finger back/forward gestures, and in the commit (fdc42cf) I just pushed, I added the back/forward gesture indicators like Chrome does. It seems to be working fairly well!

@kbhomes kbhomes closed this Mar 3, 2014

@kbhomes kbhomes modified the milestone: v1.1.0 Mar 4, 2014

@kbhomes I checked out master and built it and the gestures don't seem to be working for me? Late 2013 rMBP (64-bit) on 10.9.2.

Owner

kbhomes commented Mar 6, 2014

Do you have the preference in the Navigation section checked for enabling swipe gestures? Also, how do you usually swipe, using two or three fingers?

Yes, it is enabled in the preferences, and I tried with both two and three fingers. However, I normally use two fingers. Neither gesture works.

Owner

kbhomes commented Mar 8, 2014

I've moved the swipe tracking code from a subview into the custom web view itself. I'm not sure if this would have any effect but it's possible. Can you re-build from HEAD or wait until the 1.1.0 release and see if that changes anything?

Verified still not working in 1.1.1. I'll play with some settings on my Mac in a bit, but I'm pretty sure it should be working. Tried both 2 and 3 finger swiping, and clicked in different parts of the app to ensure something wasn't stealing focus.

Owner

kbhomes commented Mar 11, 2014

Can you go to the Trackpad settings -> More Gestures, disable the 'Swipe between full-screen apps' gesture and change the 'Swipe between pages' setting to Swipe with two or three fingers, and then try the two or three finger gestures again?

Switching to Swipe with two or three fingers worked. :) Apparently the Scroll left or right with two fingers setting does not work (which I always thought was an oddly titled setting, despite the fact that two finger back/foward works in almost all apps with that enabled?)

Bizarre. I had it set to the scroll left/right with two fingers setting so that I could use three finger drag, though it's really not that important to me.

Owner

kbhomes commented Mar 11, 2014

That's very weird, I was just wanting to know if changing that setting would have any effect. As it happens, my settings are to have "Scroll left or right with two fingers" for Swipe between pages, "Swipe left or right with three fingers" for Swipe between full screen apps, and disabled three finger drag. However, I just enabled three finger drag and was still able to use swiping in the application. This is very bizarre!

I'll play around with it more and screenshot my full settings page so we can compare later. Are you running 10.9.2? I've noticed from other projects' support groups that "gesture interference" can be a little bit weird sometimes.

screen shot 2014-03-11 at 11 11 15 pm
screen shot 2014-03-11 at 11 11 22 pm
screen shot 2014-03-11 at 11 11 28 pm

These are the settings which work. The only thing I modified was disabling three finger drag & switching to the two/three finger setting for swiping between pages. What do your settings look like?

Owner

kbhomes commented Mar 12, 2014

So to be clear, you used to have three finger drag enabled, and swipe between pages was Scroll left or right with two fingers? What did you have for swipe between full-screen apps before you changed these settings?

Here's what my settings look like:

screen shot 2014-03-11 at 22 33 02
screen shot 2014-03-11 at 22 33 08
screen shot 2014-03-11 at 22 33 11

I should mention that when I enable three-finger drag (so then three-finger settings on the More Gestures pages all turn to four-finger), the swipe gestures still seem to work for the application.

Right, the two settings I mentioned were the only ones changed from my screenshots. Enabling three-finger drag switches "Swipe between pages" to "Scroll left or right with two fingers" which breaks the functionality for me. I'm going to try replicating your settings later and see what happens.

donners commented Mar 18, 2014

The 2 finger gestures didn't work for me either, but it only took me 30 seconds to map them to the right key shorctus in BetterTouchTool (http://www.boastr.net/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment