New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign() Fix #632

Merged
merged 3 commits into from Dec 19, 2016

Conversation

Projects
None yet
2 participants
@BarakaAka1Only
Contributor

BarakaAka1Only commented Dec 16, 2016

Downloaded the new version of Radiant Player (v1.11.3) and noticed no notifications showed and the mini player stated 'No song currently playing' even upon change for a new song.

Taking a look at the console revealed that Object.assign() returns undefined making a lot of the functionality broken with Radiant Player.

Adding a Polyfill will resolve this issue in the webView

Images of the bug:

image

image

Edit:
Tested this on Mavericks, Yosemite, El Capitan and Sierra.

Issue is only present in Mavericks and Yosemite

image

but either way if Object.assign() == undefined => !!1 it will inject the Polyfill fix otherwise ignores ;)

BarakaAka1Only added some commits Sep 26, 2016

Object.assign() Fix
Object.assign() returns undefined making a lot of the functionality
broken with Radiant Player.

Adding a Polyfill will resolve this issue in the webView

Images of the bug:

http://i.imgur.com/0qvzALG.png

http://i.imgur.com/4BtRGA0.png
@jacobwgillespie

This comment has been minimized.

Show comment
Hide comment
Member

jacobwgillespie commented Dec 19, 2016

LGTM!

@jacobwgillespie jacobwgillespie merged commit a5cf704 into radiant-player:master Dec 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment