Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Sierra and above Blocked Plugin Fix + Legacy Xcode Building #671

Merged
merged 5 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@BarakaAka1Only
Copy link
Contributor

BarakaAka1Only commented Nov 2, 2018

Thanks to @xrubioj for pointing the his solution

This fix addresses the Blocked Plugin issue and UI properties are
usable than a blanked out UI from @xrubioj original PR
#670

Legacy Build System is needed so i enabled it in my workspace

Only if you set UseModernBuildSystem=NO in the Workspace setting

Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace’s
shared data, to store the state of necessary workspace checks.
Committing this file to source control will prevent unnecessary
rerunning of those checks for each user opening the workspace.

BarakaAka1Only added some commits Nov 2, 2018

macOS Sierra and above Blocked Plugin Fix + Legacy Xcode Building
Thanks to @xrubioj for pointing the his solution

This fix addresses the Blocked Plugin issue and UI properties are
usable than a blanked out UI from @xrubioj original PR
#670

Legacy Build System is needed so i enabled it in my workspace

Only if you set `UseModernBuildSystem=NO` in the Workspace setting

```
Xcode 9.3 adds a new IDEWorkspaceChecks.plist file to a workspace’s
shared data, to store the state of necessary workspace checks.
Committing this file to source control will prevent unnecessary
rerunning of those checks for each user opening the workspace.
```
@jacobwgillespie

This comment has been minimized.

Copy link
Member

jacobwgillespie commented Nov 6, 2018

I've updated the build on Travis CI so it does produce builds again, but it seems to still be crashing - @BarakaAka1Only you want to take a look when you have a moment?

BarakaAka1Only added some commits Nov 7, 2018

Correction
Word correction
@BarakaAka1Only

This comment has been minimized.

Copy link
Contributor Author

BarakaAka1Only commented Nov 7, 2018

@jacobwgillespie I went ahead and merged all the changes and everything passed ;)

@xrubioj

This comment has been minimized.

Copy link
Contributor

xrubioj commented Nov 7, 2018

@BarakaAka1Only @jacobwgillespie See issue #674 about the crash. :) I suggest to move the discussion there in order to not duplicate efforts.

@BarakaAka1Only

This comment has been minimized.

Copy link
Contributor Author

BarakaAka1Only commented Nov 28, 2018

@jacobwgillespie @xrubioj sorry been very busy at work i went ahead and merged the branch with @xrubioj excellent fix for the crash issue so that the rest with the non-media keys and such (blocked plug-in) is fixed! (yes i've tested it before merging)

@jacobwgillespie jacobwgillespie merged commit c242bc3 into radiant-player:master Mar 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.