New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a verification on whether the process is trusted for Accessibility #676

Merged
merged 1 commit into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@xrubioj
Contributor

xrubioj commented Nov 18, 2018

This fixes/mitigates the issue #674: "Application will not restart after update in macOS Mojave".

There are two possible cases here:

  • app is started for the first time (or permission was removed). In that case, permission for Radiant Player will be shown in the System Preferences -> Privacy -> Accessibility, but it will be unchecked. This is the most obvious case for the user.
  • app has been updated. In this case, permission for Radiant Player will be shown in the System Preferences -> Privacy -> Accessibility and it will be checked. The user needs to uncheck it and then check it again. This is not obvious at all.

This fix shows an alert explaining both cases to the user, offers the user to open the System Preferences (should be shown in both cases, not only for the first case, which was the previous behavior). This makes clear that Radiant Player will close, and that the user needs to grant the permission and restart Radiant Player manually. Also, explains the steps to be taken for the second case, so it's clear for the user that even if the permission is checked, in needs to be disabled and reenabled.

Adds a verification on whether the process is trusted for Accessibility
This fixes/mitigates the issue #674: "Application will not restart after
update in macOS Mojave"
@jacobwgillespie

This comment has been minimized.

Member

jacobwgillespie commented Nov 18, 2018

Thanks for this!

@jacobwgillespie jacobwgillespie merged commit 1ae4ab7 into radiant-player:master Nov 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jacobwgillespie

This comment has been minimized.

Member

jacobwgillespie commented Nov 18, 2018

After Travis CI builds, this should be released as v1.11.7.

@xrubioj

This comment has been minimized.

Contributor

xrubioj commented Nov 18, 2018

Great! Thanks. Now I'm working in #675. I think I have a clue on what's going on. I'll post updates there. Hope to have it finished soon. 😄

@xrubioj xrubioj deleted the xrubioj:accessibility-verification branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment