'children:each' calls broken method in radiant-archive-extension #155

Closed
dkreft opened this Issue Sep 30, 2010 · 1 comment

Comments

Projects
None yet
2 participants
@dkreft

dkreft commented Sep 30, 2010

On this line: http://github.com/radiant/radiant/blob/master/app/models/standard_tags.rb#L120, we see the following call:

tag.locals.children.all(options)

Which breaks the archive extension because of a bad method signature there (see http://github.com/radiant/radiant-archive-extension/issues/issue/2).

Granted this is the extension owner's problem, but this used to say:

tag.locals.children.find(:all, options)

Which works great. This is also the same approach used in the "children:first" tag in the same file. Might it be a good idea to go back to using #find(method, options) instead of #all(options)?

@saturnflyer

This comment has been minimized.

Show comment Hide comment
@saturnflyer

saturnflyer Mar 22, 2011

Owner

fix archive children ordering. Closed by fd61c84. Closed by fd61c84

Owner

saturnflyer commented Mar 22, 2011

fix archive children ordering. Closed by fd61c84. Closed by fd61c84

jomz pushed a commit to jomz/radiant that referenced this issue Apr 20, 2011

rx pushed a commit to voomify/radiant that referenced this issue Jul 19, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment