i18n Vendored Rails Translations #173

Closed
dirkkelly opened this Issue Dec 7, 2010 · 7 comments

Comments

Projects
None yet
4 participants
@dirkkelly

Looks like the vendored rails is still using the double moustache syntax of translations, eg:

rails/actionpack/lib/action_view/locale/en.yml

This is fixed in 2.3.10 of actionpack, could we look at upgrading edge?

@saturnflyer

This comment has been minimized.

Show comment
Hide comment
@saturnflyer

saturnflyer Dec 7, 2010

Member

As far as I understand, there is a bug in a version of rack that rails requires in 2.3.10 which truncates the contents of textareas.

Member

saturnflyer commented Dec 7, 2010

As far as I understand, there is a bug in a version of rack that rails requires in 2.3.10 which truncates the contents of textareas.

@dirkkelly

This comment has been minimized.

Show comment
Hide comment
@dirkkelly

dirkkelly Dec 7, 2010

Ahhh lame. I was looking for a reason why we hadn't upgraded.

Should I manually fix these and send a pull request...at least that fixes the immediate issue?

Ahhh lame. I was looking for a reason why we hadn't upgraded.

Should I manually fix these and send a pull request...at least that fixes the immediate issue?

@saturnflyer

This comment has been minimized.

Show comment
Hide comment
@saturnflyer

saturnflyer Dec 7, 2010

Member

that'd be fine with me.

Member

saturnflyer commented Dec 7, 2010

that'd be fine with me.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 7, 2010

I tried to put in a sort of monkeypatch for the i18n and found it's not that easy. The much easier option is to downgrade your i18n gem to 0.3.7, if other projects will allow. Perhaps we should vendor that, temporarily?

ghost commented Dec 7, 2010

I tried to put in a sort of monkeypatch for the i18n and found it's not that easy. The much easier option is to downgrade your i18n gem to 0.3.7, if other projects will allow. Perhaps we should vendor that, temporarily?

@dirkkelly

This comment has been minimized.

Show comment
Hide comment
@dirkkelly

dirkkelly Dec 7, 2010

cheers, i'll see what I can sort out :-)

cheers, i'll see what I can sort out :-)

@michaelstalker

This comment has been minimized.

Show comment
Hide comment
@michaelstalker

michaelstalker Jun 7, 2011

Contributor

You can create a preinitializer.rb file and stick it in your config folder to take care of this. See http://www.taylorbrooks.org/error-messages-in-rails-attribute-message/

Contributor

michaelstalker commented Jun 7, 2011

You can create a preinitializer.rb file and stick it in your config folder to take care of this. See http://www.taylorbrooks.org/error-messages-in-rails-attribute-message/

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jun 8, 2011

We're on 2.3.11 now so this shouldn't be a problem any more.

ghost commented Jun 8, 2011

We're on 2.3.11 now so this shouldn't be a problem any more.

@ghost ghost closed this Jun 8, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment