Page Preview #319

Closed
blj opened this Issue Feb 10, 2012 · 12 comments

Comments

Projects
None yet
3 participants
Contributor

blj commented Feb 10, 2012

Am I the only one have problem with this feature? I experience these issues:

(a) Preview actually saves the page.
(b) After preview is rendered, I click on Edit page and then make changes and hit preview button, it throws error.

Can others please confirm if they also have similar problem?

Owner

johnmuhl commented Feb 10, 2012

is this RC4 or master or ...?

Contributor

blj commented Feb 10, 2012

on master.

Contributor

blj commented Feb 10, 2012

I think the problem is with the nested transaction blocks in render_preview method. I will fix and send a pull request.

Contributor

blj commented Feb 10, 2012

also in RC4.

Owner

johnmuhl commented Feb 11, 2012

i don't have either problem. anybody else?

is there anything else interesting about your radiant setup? extensions, etc.

Contributor

blj commented Feb 14, 2012

I have disabled all extensions and still get the same issue.

Owner

johnmuhl commented Feb 14, 2012

what about ruby version and os?

Contributor

blj commented Feb 15, 2012

Ruby version 1.8.7, have problem in both OSX and Debian.

Contributor

blj commented Feb 15, 2012

I used a fresh radiant install and pointed to an existing mysql database which had radiant structure. I have the same issue. I am beginning to think that MySQL does not do nested transaction well. I need dig into this. In any case, I do not see the point of opening two transaction blocks.

Owner

johnmuhl commented Feb 15, 2012

i'm not sure why it's that way either. @saturnflyer?

could you put your fork up on travis and see if any specs break?

Contributor

blj commented Feb 15, 2012

Sure, I have never used travis before, but I will try now. do we have an irc channel for radiant? if not will be online on #rubyonrails(blj) if you can guide me, it will be much appreciated. Thanks.

Contributor

blj commented Feb 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment