Clean up bundler requires. #332

Merged
merged 1 commit into from Aug 27, 2012

Conversation

Projects
None yet
3 participants
Contributor

envygeeks commented Apr 26, 2012

I think this is the best approach, it doesn't explicitly require Bundler and all the other checks should really be done in the gemspec IMO. The main problem I had that prompted me to make this pull request is the fact that you guys completely assume that I use Gemfile and kill my predefined BUNDLE_GEMFILE so now I am either stuck with the badly named Gemfile instead of gemfile.rb that I would prefer for my projects. At the least I think it should not overwrite BUNDLE_GEMFILE.

Owner

saturnflyer commented Apr 30, 2012

thanks @envygeeks! would you be able to address what @gerrit mentioned?

Contributor

envygeeks commented Jun 30, 2012

Sorry for the delay, been extremely busy these past months, I've updated it... though I don't know if the RADIANT_NOWARNINGS will fly with ya'll considering it's an undocumented refactor to the way Radiant acts, but I like the idea of being able to silence Radiant warnings like that when some users might not prefer bundler.

This pull request passes (merged c98a2ed8 into 60ac92e).

This pull request passes (merged 9e7e703 into 60ac92e).

saturnflyer added a commit that referenced this pull request Aug 27, 2012

@saturnflyer saturnflyer merged commit f927223 into radiant:master Aug 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment