Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add an extension for visualization parameters. #470

Open
wants to merge 3 commits into
base: master
from

Conversation

@emsal1863
Copy link

commented Jun 5, 2019

The primary purpose of this extension is to allow collections to
specify the default way they are to be visualized or overlayed onto a
map.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all. to update the generated OpenAPI files.
emsal1863 added 3 commits Jun 5, 2019
The primary purpose of this extension is to allow tabular collections to
specify the default way they are to be visualized or overlayed onto a
map.
TODO: how would we make these more general?
@m-mohr m-mohr changed the title Add an extension for visualization parameters. WIP: Add an extension for visualization parameters. Jun 6, 2019
@mojodna mojodna self-assigned this Jun 6, 2019
Copy link
Member

left a comment

I'm reading this primarily from the perspective of "could I translate this into query params on a TMS server and produce sensible imagery", and I just about could if I understood the two questions below


| Field Name | Type | Description |
|------------|----------|------------------------------------------------------------------------------------------------|
| min | [double] | Minimum value of each band. If only one value then it is applied as the minimum for all bands. |

This comment has been minimized.

Copy link
@jisantuc

jisantuc Jun 7, 2019

Member

Is there some way to express optionality? For example, in Raster Foundry land, we consider these optional, since we assume for color correction that we have statistical information about the image, but that a user might want to override it. Does that match the intention here?

This comment has been minimized.

Copy link
@m-mohr

m-mohr Jun 7, 2019

Collaborator

In STAC everything that is not required explicitly is optional.

This comment has been minimized.

Copy link
@jisantuc

jisantuc Jun 7, 2019

Member

I mean optional in the "value or null" sense on the individual array items. For example, if I had some bands where I want to set a minimum, but not others, I don't believe I can express that here (unless I've gotten too used to types, and [0, null, 0] would be a valid value here)

| Field Name | Type | Description |
|------------|---------|--------------------------------------------------------|
| band_vis | BandVis | Vis args for the given band_names. |
| global_vis | BandVis | If vis_args are present here, they apply to all bands. |

This comment has been minimized.

Copy link
@jisantuc

jisantuc Jun 7, 2019

Member

It looks like there are two places where you can specify global viz arguments -- in band_vis, if you provide only one value in the array parameters, or here -- am I reading this correctly that those could conflict? If so, does global_vis take precedence? Under what circumstances should someone provide both global_vis and band_vis?

This comment has been minimized.

Copy link
@emsal1863

emsal1863 Jun 10, 2019

Author

In Earth Engine it's handled like this:
In ImageVisualization a number of band_names are specified. For each of these bands, the BandVis in band_vis is applied. But for ALL bands of the Image/ImageCollection, the visualization parameters in global_vis are applied.

@matthewhanson matthewhanson referenced this pull request Jun 9, 2019
3 of 3 tasks complete
@m-mohr m-mohr added this to the future milestone Aug 19, 2019
@m-mohr m-mohr referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.