Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions to training data/label extension #481

Conversation

@aaronxsu
Copy link
Contributor

commented Jun 6, 2019

This PR suggests some changes based on the training data PR. It also adds some linked examples under the implementations section as a result of the proposed changes.

This PR is a result of discussions among @daveluo, @nrweir, @philvarner, @mteldridge, and yours truly during STAC Sprint 4 in San Francisco, CA, June 4th to 6th, 2019.

philvarner and others added 27 commits Jun 5, 2019
…lder
@matthewhanson

This comment has been minimized.

Copy link
Collaborator

commented Jun 9, 2019

Briefly looked at this, but going to go ahead and merge it into the #362 where we can discuss from there.
I'll give it a more thorough review this upcoming week.

@matthewhanson matthewhanson merged commit 7a71b3e into radiantearth:extension/training_data Jun 9, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@mojodna

This comment has been minimized.

Copy link
Member

commented on extensions/label/README.md in 0b87748 Jun 26, 2019

@daveluo (et al): the Zanzibar example has a list of classes (because there are multiple label properties); should this always be [Class Object] vs. needing to check list or object?

This comment has been minimized.

Copy link
Contributor

replied Jun 27, 2019

Good thought, I think this should always be [Class Object] even when it reduces to a single label and single class dataset like in the spacenet-buildings example. It's also consistent with how we use [Count Object] and [Stats Object] in label:overview.

Related: I'll update the zanzibar examples to add the Count Object for the "condition" label property so it's a complete example of multi-label multi-class data.

@hgs-msmith hgs-msmith referenced this pull request Aug 20, 2019
2 of 3 tasks complete
@mojodna

This comment has been minimized.

Copy link
Member

commented on extensions/label/README.md in f5bf0fb Sep 30, 2019

Since assets is an object, there can be a maximum of one asset that uses the key "labels". Should rel be used instead?

@mojodna

This comment has been minimized.

Copy link
Member

commented on extensions/label/README.md in 0b87748 Oct 1, 2019

@daveluo (et al): this should probably always be [Label Overview Object] in order to support summarizations of multiple labels. As-is, only one label property can be summarized (though the Zanzibar example includes this as a list).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.