New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue related to plugin loading order #905

Closed
robnagler opened this Issue Oct 6, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@robnagler
Member

robnagler commented Oct 6, 2017

I think the root cause is the plugin order is random (see pytest-dev/pytest#935). I thought I could force the order by reinstalling xdist and forked. That didn't fix things. We don't need xdist as "--boxed" has recently been forked to pytest-forked, which is what we need to run our tests in separate processes.

Still failing https://travis-ci.org/radiasoft/sirepo/builds/284326211

@robnagler robnagler added 1 bug labels Oct 6, 2017

@robnagler robnagler self-assigned this Oct 6, 2017

robnagler added a commit to radiasoft/pykern that referenced this issue Oct 6, 2017

Working on radiasoft/sirepo#905
removed xdist, because it may be the issue. just having
pytest-forked may work right. Use --forked.

robnagler added a commit that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/download that referenced this issue Oct 6, 2017

Working on radiasoft/sirepo#905
removed xdist, because it may be the issue.
just having pytest-forked may work right

robnagler added a commit to radiasoft/pykern that referenced this issue Oct 6, 2017

Another try at radiasoft/sirepo#905
One of the pytest authors responded:
pytest-dev/pytest#935 (comment)
There's no way to force dependencies for pytest plugins.

robnagler added a commit that referenced this issue Oct 6, 2017

Another try at #905
One of the pytest authors responded:
pytest-dev/pytest#935 (comment)
There's no way to force dependencies for pytest plugins.

robnagler added a commit to radiasoft/rslinac that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rsbeams that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/ioptics that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/olive that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rscooler that referenced this issue Oct 6, 2017

@robnagler

This comment has been minimized.

Show comment
Hide comment
@robnagler

robnagler Oct 6, 2017

Member

Well that was fun. I fixed this by adding a conftest.py. I updated all our pykern projects even though few have tests :).

@mrakitin you'll need to update mrakitin/bnlcrl. Here's an example commit radiasoft/rscooler@09d0883

This is pretty much all you need to do:

cd ~/src/radiasoft/pykern
git pull 
cd ~/src/mrakitin/bnlcrl/tests
git pull
cp ~/src/radiasoft/pykern/tests/conftest.py .
git add conftest.py
git commit -m 'See radiasoft/pykern#18 and radiasoft/sirepo#905' conftest.py
git push
Member

robnagler commented Oct 6, 2017

Well that was fun. I fixed this by adding a conftest.py. I updated all our pykern projects even though few have tests :).

@mrakitin you'll need to update mrakitin/bnlcrl. Here's an example commit radiasoft/rscooler@09d0883

This is pretty much all you need to do:

cd ~/src/radiasoft/pykern
git pull 
cd ~/src/mrakitin/bnlcrl/tests
git pull
cp ~/src/radiasoft/pykern/tests/conftest.py .
git add conftest.py
git commit -m 'See radiasoft/pykern#18 and radiasoft/sirepo#905' conftest.py
git push

@robnagler robnagler closed this Oct 6, 2017

robnagler added a commit to radiasoft/rsoopic that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rssympim that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rssynergia that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rszgoubi that referenced this issue Oct 6, 2017

robnagler added a commit to radiasoft/rsfriction that referenced this issue Oct 6, 2017

mrakitin added a commit to mrakitin/bnlcrl that referenced this issue Oct 7, 2017

robnagler added a commit to radiasoft/rsconf that referenced this issue Oct 8, 2017

@mrakitin

This comment has been minimized.

Show comment
Hide comment
@mrakitin

mrakitin Oct 10, 2017

Collaborator

Thanks @robnagler, I've followed the steps and updated the package.

Collaborator

mrakitin commented Oct 10, 2017

Thanks @robnagler, I've followed the steps and updated the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment