Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make to-json work on more inputs. #578

Merged
merged 4 commits into from Mar 22, 2019

Conversation

Projects
None yet
2 participants
@jameshaydon
Copy link
Collaborator

commented Mar 19, 2019

Now also converts:

  • vectors,
  • keywords,
  • dicts with mixed string/keyword keys.

@jameshaydon jameshaydon force-pushed the f/more-lenient-to-json branch 3 times, most recently from 43411e0 to 0e08376 Mar 19, 2019

@jameshaydon jameshaydon requested a review from jkarni Mar 20, 2019

@jameshaydon jameshaydon changed the title [WIP] Make to-json work on more inputs. Make to-json work on more inputs. Mar 20, 2019

@jameshaydon jameshaydon requested a review from MeBrei Mar 20, 2019

booleans are converted to their JSON counterparts. Keywords are
converted to JSON strings (dropping the initial ':'). Lists and vectors
are converted to JSON arrays. Dicts are converted to JSON objects as
long as all the keys are either strings of keywords.

This comment has been minimized.

Copy link
@MeBrei

MeBrei Mar 22, 2019

Member

strings or keywords ?

@MeBrei

MeBrei approved these changes Mar 22, 2019

jameshaydon added some commits Mar 19, 2019

Make to-json work on more inputs.
Now also converts:
- vectors,
- keywords,
- dicts with mixed string/keyword keys.

@jameshaydon jameshaydon force-pushed the f/more-lenient-to-json branch from 4d9bdfc to 620739b Mar 22, 2019

@jameshaydon jameshaydon merged commit ac6e647 into master Mar 22, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@jameshaydon jameshaydon deleted the f/more-lenient-to-json branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.