This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add e2e patch tests for unauthorized commands #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeBrei
force-pushed
the
f/more-patch-tests
branch
from
a2ff776
to
7ae588c
Compare
jameshaydon
reviewed
Mar 20, 2019
| step "rad patch reject fails (contributer)" | ||
| _ <- runTestCommand "rad-key" ["create", "--force"] | ||
| rejectOutput <- runTestCommandForError "rad-patch" ["reject", "0"] | ||
| assertContains rejectOutput "Are you authorized to do so?" |
There was a problem hiding this comment.
I think it would be less brittle to check for "error". Unrelated to this PR, but I note that in error-messages.rad, some messages are prefixed with error:, some with Error: and some not prefixed at all. Maybe this should be made consistent.
There was a problem hiding this comment.
👍 I can create another issue for that
test/e2e/Test/E2ESupport.hs
Outdated
| -- | Like 'runTestCommand'' but expects the command to return an error. | ||
| -- | ||
| -- If the command exits with a non-zero exit code, an exception is thrown. | ||
| -- Otherwise stdout of the error is returned. |
There was a problem hiding this comment.
Suggested change
| -- Otherwise stdout of the error is returned. | |
| -- Otherwise stdout of the command is returned. |
jameshaydon
suggested changes
Mar 20, 2019
test/e2e/Test/E2ESupport.hs
Outdated
| let commandLine = bin <> " " <> unwords argsString | ||
| in liftIO $ HUnit.assertFailure $ | ||
| "Command " <> commandLine <> " succeeded,\n" | ||
| <> "but was expected to fail." |
There was a problem hiding this comment.
I think printing stdout and stderr would be helpful here, too.
geigerzaehler
approved these changes
Mar 21, 2019
jameshaydon
approved these changes
Mar 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.