Improve test coverage

[erwanp]

17/01/20 : Test coverage is about 70%.

Edit : 17/02/21 : 78%, getting there! 💪

Edit :: 12/11/21 : down to 75% :(

Edit : 21/03/22 : up to 77%

• Goal:: should be > 80%.

That's a good issue to learn about the package!

Identify modules that need the more coverage :

• for instance a MergeSlabs with intersect: https://codecov.io/gh/radis/radis/pull/91/src/radis/los/slabs.py#L464

• in base.py there are the _add_EvibErot_CDSD_pc and _add_Evib123Erot_CDSD_pc function (advanced calculations for nonequilibrium CO2 in "p,c,j,n" nomenclature ) . See how the similar _add_EvibErot_CDSD_pcN function was tested in Add online tests for calculations per band, and CO2 (p,c,j,n) nonequilibrium modes #99

Clean deprecated parts of the code (ask on Gitter if needed)

Add new tests as needed

• for instance move _test() from misc/signals.py in the test folder. And run it.

• maybe exclude some parts from the coverage: see https://coverage.readthedocs.io/en/v4.5.x/excluding.html#advanced-exclusion

[erwanp]

Added some room for more coverage with #91 by adding files to test the different CO2 nonequilibrium models.

[sagarchotalia]

Some of the current functions in the code that aren't being covered:

In radis/db:

• In classes.py
  • _E_Herzberg()
  • convert()

In radis/io:

• In exomolapi.py
  • make_j2b()
  • make_jj2b()
• npy.py has 0.00% coverage
• In query.py
  • _fix_astroquery_file_format()
• spec_hdf.py has 0.00% coverage

In radis/lbl:

• In bands.py:
  • get_bands_weight()
  • get_band_list()
  • get_band()
  • docstring_parameter()
• In base.py:
  • plot_hist()
  • _add_EvibErot_CDSD_pc()
  • _add_Evib123Erot_CDSD_pc()
  • calc_reference_linestrength()
• In broadening.py:
  • plot_broadening()
• In gpu.py:
  • py_calc_lorentzian_envelope_params()
  • constant_memory_setter()
• In loader.py:
  • copy()
  • get_best_match()
• In overp.py:
  • plot_vib_populations()
  • eq_spectrum()

In radis/misc

• In arrays.py:

  • first_nonnan_index()
  • last_nonnan_index
  • is_sorted()
  • is_sorted_backward()
  • non_zero_values_around()
  • non_zero_ranges_in_array()
  • boolean_array_from_ranges()
  • sparse_add_at()

• In config.py:

  • get_user_config_configformat()
  • convertRadisToJSON()
  • createConfigFile()
  • getDatabankEntries_configformat()
  • getDatabankList_configformat()
  • addDatabankEntries_configformat()
  • printDatabankEntries_configformat()
  • printDatabankList_configformat()

I think the above functions should be enough to get started, although I will update this list in the future to include all the functions that aren't being covered.

[erwanp]

Amazing list, thank you it's a nice guidance to get started !!

[BuerJeanMaxime]

Is it still open ? I'd would to take a look at that !