Fix recipe pack OCI tags to use full semver version#12027
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Fixes a tag-mismatch bug where GetCoreTypesRecipeInfo constructed core resource type recipe OCI image references using version.Channel() (e.g., 0.58) while the kube-recipes publishing pipeline tags images with the full semver (e.g., 0.58.0), causing RecipeDownloadFailed. The fix switches to version.Release() for release builds while preserving the latest tag fallback for edge/dev builds.
Changes:
- Replace
version.Channel()withversion.Release()for the OCI recipe tag. - Update the function's doc comment to reflect the new tag format.
7cabe0e to
5ff22e6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12027 +/- ##
==========================================
+ Coverage 51.95% 51.97% +0.01%
==========================================
Files 732 732
Lines 46305 46305
==========================================
+ Hits 24059 24068 +9
+ Misses 19948 19944 -4
+ Partials 2298 2293 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5ff22e6 to
477a52d
Compare
477a52d to
3046cb7
Compare
Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
3046cb7 to
d345d78
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
This pull request updates how the OCI tag is determined for core resource type recipes in the
GetCoreTypesRecipeInfofunction. Instead of using the version channel (like "0.40" or "edge"), it now uses the full semantic version (like "0.58.0") to align with tags from the kube-recipes publishing pipeline. For edge or development builds, "latest" is still used.note: tests for this update will be included in pr: #12012
Type of change
Fixes: #12026
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.