Skip to content

Fix recipe pack OCI tags to use full semver version#12027

Merged
lakshmimsft merged 1 commit into
mainfrom
fix/recipe-tag-version
Jun 4, 2026
Merged

Fix recipe pack OCI tags to use full semver version#12027
lakshmimsft merged 1 commit into
mainfrom
fix/recipe-tag-version

Conversation

@lakshmimsft

@lakshmimsft lakshmimsft commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This pull request updates how the OCI tag is determined for core resource type recipes in the GetCoreTypesRecipeInfo function. Instead of using the version channel (like "0.40" or "edge"), it now uses the full semantic version (like "0.58.0") to align with tags from the kube-recipes publishing pipeline. For edge or development builds, "latest" is still used.

note: tests for this update will be included in pr: #12012

Type of change

Fixes: #12026

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document is added or updated under eng/design-notes/ in this repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for resource-types-contrib is created, if resource types or recipes are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for dashboard is created, if the Radius Dashboard is affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable

Copilot AI review requested due to automatic review settings June 1, 2026 17:10
@lakshmimsft lakshmimsft requested review from a team as code owners June 1, 2026 17:10
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a tag-mismatch bug where GetCoreTypesRecipeInfo constructed core resource type recipe OCI image references using version.Channel() (e.g., 0.58) while the kube-recipes publishing pipeline tags images with the full semver (e.g., 0.58.0), causing RecipeDownloadFailed. The fix switches to version.Release() for release builds while preserving the latest tag fallback for edge/dev builds.

Changes:

  • Replace version.Channel() with version.Release() for the OCI recipe tag.
  • Update the function's doc comment to reflect the new tag format.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

Unit Tests

    2 files  ±0    435 suites  ±0   7m 35s ⏱️ +16s
5 250 tests ±0  5 248 ✅ ±0  2 💤 ±0  0 ❌ ±0 
6 372 runs  ±0  6 370 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit d345d78. ± Comparison against base commit 2aa4f45.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.97%. Comparing base (2aa4f45) to head (d345d78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12027      +/-   ##
==========================================
+ Coverage   51.95%   51.97%   +0.01%     
==========================================
  Files         732      732              
  Lines       46305    46305              
==========================================
+ Hits        24059    24068       +9     
+ Misses      19948    19944       -4     
+ Partials     2298     2293       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lakshmimsft lakshmimsft requested a review from sk593 June 3, 2026 16:23
@lakshmimsft lakshmimsft force-pushed the fix/recipe-tag-version branch from 5ff22e6 to 477a52d Compare June 4, 2026 04:16
@lakshmimsft lakshmimsft enabled auto-merge (squash) June 4, 2026 05:32
@lakshmimsft lakshmimsft force-pushed the fix/recipe-tag-version branch from 477a52d to 3046cb7 Compare June 4, 2026 05:40
Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
@lakshmimsft lakshmimsft force-pushed the fix/recipe-tag-version branch from 3046cb7 to d345d78 Compare June 4, 2026 17:33
@radius-functional-tests

radius-functional-tests Bot commented Jun 4, 2026

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref d345d78
Unique ID funcb1e9d6c41a
Image tag pr-funcb1e9d6c41a
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb1e9d6c41a
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb1e9d6c41a
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb1e9d6c41a
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb1e9d6c41a
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb1e9d6c41a
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft merged commit 17780af into main Jun 4, 2026
59 checks passed
@lakshmimsft lakshmimsft deleted the fix/recipe-tag-version branch June 4, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default recipe pack creation uses version.Channel() causing mismatch with recipe images which have full semver tags

3 participants