Open
Conversation
andresz1
requested review from
andy-hook,
benoitgrelard,
lucasmotta and
vladmoroz
as code owners
kikoruiz
approved these changes
Apr 23, 2024
andresin87
approved these changes
Apr 29, 2024
|
👍 |
chaance
requested review from
StephenHaney,
chaance and
hadihallak
as code owners
chaance
added
Resolution: Needs Investigation
|
@chaance Could you please merge this? This can have meaningful impact on INP. |
|
Recently, my INP was degraded by the same reason that this PR tries to fix. It would be nice if we could merge it! 🙏🏻 Thank you @andresz1! 👏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves
Dialogcomponent INP performance by prioritising paint whenmodalprop is set totruesetTimeoutto avoid doing synchronously before the paint.Before
After