New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds percentage width, background color and fixes #6

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@wassgha

wassgha commented Sep 1, 2018

  • Now takes any supported width unit (percentages, pixels, etc.)
  • Makes the width prop optional (defaults to '100%')
  • Takes into account the maxValue when calculating the percentage (used to be wrong)
  • Added style for the background color of the component itself (used to be only transparent)

wassgha added some commits Sep 1, 2018

@wassgha

This comment has been minimized.

Show comment
Hide comment
@wassgha

wassgha commented Sep 1, 2018

@rafaelmotta please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment