Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds theme configuration & different iconography for debug / release builds #8

Merged
merged 3 commits into from Mar 30, 2018

Conversation

@rafaeltoledo
Copy link
Owner

@rafaeltoledo rafaeltoledo commented Mar 29, 2018

As a way to correctly and efficiently know about which version we are running, and for easier identification of the app versions when both of them are installed on the device, the theme colors were inverted in the debug build (primary and accent colors).

This PR also updates Kotlin, AGP & Google libraries.

To help the developers and testers to better identify the development
and production app, the color scheme (primary and accent) is inverted on
debug and release build types.
@rafaeltoledo rafaeltoledo requested a review from tpinho Mar 29, 2018
@rafaeltoledo
Copy link
Owner Author

@rafaeltoledo rafaeltoledo commented Mar 29, 2018

Please, squash on merge :)

Makes sense to not squash in this specific case, as commits are separated, each own modifying its own thing.

@tpinho
tpinho approved these changes Mar 30, 2018
@tpinho tpinho merged commit 8d732fd into develop Mar 30, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@tpinho tpinho deleted the rt/app-theme branch Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants