Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Code Coverage #9

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Adds Code Coverage #9

merged 3 commits into from
Apr 10, 2018

Conversation

rafaeltoledo
Copy link
Owner

@rafaeltoledo rafaeltoledo commented Apr 9, 2018

This PR adds the code coverage after successfully running tests. Sometime in a future, we'll need to think about how to run the instrumented tests on CI server to get a more precise metric - I played a bit using a headless emulator but didn't get success.

For registering coverage data, I'm using Coveralls. I tried to use Codecov, but it didn't work well with Kotlin yet. Would be good to add a coverage metric when opening PRs, when possible.

This also updates Support Library to 27.1.1 and AGP to 3.1.1

This will allow us to push some coverage data to Codecov.io, and display
its badge on our README.
@tpinho tpinho merged commit 0fcc845 into develop Apr 10, 2018
@tpinho tpinho deleted the rt/code-coverage branch April 10, 2018 12:43
apply plugin: 'com.github.kt3k.coveralls'

jacoco {
toolVersion = "$versions.jacoco"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not simply jacoco.toolVersion versions.jacoco ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a nitpick, but anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants