Adds Code Coverage #9
Merged
Conversation
This will allow us to push some coverage data to Codecov.io, and display its badge on our README.
| apply plugin: 'com.github.kt3k.coveralls' | ||
|
|
||
| jacoco { | ||
| toolVersion = "$versions.jacoco" |
cs-victor-nascimento
Apr 10, 2018
Why not simply jacoco.toolVersion versions.jacoco ?
Why not simply jacoco.toolVersion versions.jacoco ?
cs-victor-nascimento
Apr 10, 2018
It is just a nitpick, but anyway...
It is just a nitpick, but anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds the code coverage after successfully running tests. Sometime in a future, we'll need to think about how to run the instrumented tests on CI server to get a more precise metric - I played a bit using a headless emulator but didn't get success.
For registering coverage data, I'm using Coveralls. I tried to use Codecov, but it didn't work well with Kotlin yet.
Would be good to add a coverage metric when opening PRs, when possible.This also updates Support Library to 27.1.1 and AGP to 3.1.1