New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Code Coverage #9

Merged
merged 3 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@rafaeltoledo
Owner

rafaeltoledo commented Apr 9, 2018

This PR adds the code coverage after successfully running tests. Sometime in a future, we'll need to think about how to run the instrumented tests on CI server to get a more precise metric - I played a bit using a headless emulator but didn't get success.

For registering coverage data, I'm using Coveralls. I tried to use Codecov, but it didn't work well with Kotlin yet. Would be good to add a coverage metric when opening PRs, when possible.

This also updates Support Library to 27.1.1 and AGP to 3.1.1

rafaeltoledo added some commits Apr 9, 2018

Adds initial coverage setup and a simple test
This will allow us to push some coverage data to Codecov.io, and display
its badge on our README.

@rafaeltoledo rafaeltoledo requested review from tpinho and victorolinasc Apr 9, 2018

@tpinho

tpinho approved these changes Apr 10, 2018

@tpinho tpinho merged commit 0fcc845 into develop Apr 10, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@tpinho tpinho deleted the rt/code-coverage branch Apr 10, 2018

apply plugin: 'com.github.kt3k.coveralls'
jacoco {
toolVersion = "$versions.jacoco"

This comment has been minimized.

@cs-victor-nascimento

cs-victor-nascimento Apr 10, 2018

Why not simply jacoco.toolVersion versions.jacoco ?

This comment has been minimized.

@cs-victor-nascimento

cs-victor-nascimento Apr 10, 2018

It is just a nitpick, but anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment